Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add experemental support for Machinepool #89

Merged
merged 1 commit into from
May 20, 2022
Merged

feat: add experemental support for Machinepool #89

merged 1 commit into from
May 20, 2022

Conversation

joekr
Copy link
Member

@joekr joekr commented May 16, 2022

What this PR does / why we need it:
This adds support for Machine Pools https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20190919-machinepool-api.md

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #32

@joekr joekr added the enhancement New feature or request label May 16, 2022
@joekr joekr self-assigned this May 16, 2022
@joekr
Copy link
Member Author

joekr commented May 16, 2022

Commits still need to be squashed, but I wanted to put this into draft to get feedback and it is also easier for me to review via the "files changed" ui.

@joekr joekr force-pushed the machinepool-poc branch 2 times, most recently from 2e016ec to c969542 Compare May 17, 2022 02:15
shyamradhakrishnan
shyamradhakrishnan reviewed May 17, 2022
View reviewed changes
templates/cluster-template-machinepool.yaml Outdated Show resolved Hide resolved
templates/cluster-template-machinepool.yaml Outdated Show resolved Hide resolved
templates/cluster-template-machinepool.yaml Outdated Show resolved Hide resolved
feature/gates.go Show resolved Hide resolved
feature/feature.go Outdated Show resolved Hide resolved
exp/controllers/ocimachinepool_controller.go Outdated Show resolved Hide resolved
exp/controllers/ocimachinepool_controller.go Outdated Show resolved Hide resolved
exp/api/v1beta1/ocimachinepool_types.go Outdated Show resolved Hide resolved
exp/api/v1beta1/ocimachinepool_types.go Outdated Show resolved Hide resolved
cloud/ociutil/ociutil.go Show resolved Hide resolved
@joekr joekr force-pushed the machinepool-poc branch 9 times, most recently from 97a8088 to be9bbfd Compare May 19, 2022 03:04
shyamradhakrishnan
shyamradhakrishnan reviewed May 19, 2022
View reviewed changes
exp/controllers/ocimachinepool_controller.go Outdated Show resolved Hide resolved
exp/controllers/ocimachinepool_controller.go Outdated Show resolved Hide resolved
exp/controllers/ocimachinepool_controller.go Outdated Show resolved Hide resolved
exp/api/v1beta1/ocimachinepool_types.go Outdated Show resolved Hide resolved
exp/controllers/ocimachinepool_controller.go Show resolved Hide resolved
@joekr joekr force-pushed the machinepool-poc branch 5 times, most recently from c80d1a3 to 562c295 Compare May 19, 2022 19:47
@joekr
Copy link
Member Author

joekr commented May 19, 2022

unit test

?       github.com/oracle/cluster-api-provider-oci      [no test files]
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta1  0.266s  coverage: 18.6% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/config [no test files]
ok      github.com/oracle/cluster-api-provider-oci/cloud/ociutil        0.117s  coverage: 25.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/scope  175.784s        coverage: 74.5% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks    [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute       [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement     [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity      [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity        [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn  [no test files]
ok      github.com/oracle/cluster-api-provider-oci/controllers  26.190s coverage: 71.0% of statements
?       github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1      [no test files]
?       github.com/oracle/cluster-api-provider-oci/exp/controllers      [no test files]
?       github.com/oracle/cluster-api-provider-oci/feature      [no test files]

e2e

Ran 5 of 21 Specs in 1882.236 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 16 Skipped

@joekr joekr marked this pull request as ready for review May 19, 2022 19:51
@joekr joekr mentioned this pull request May 19, 2022
Closed
4 tasks
shyamradhakrishnan
shyamradhakrishnan reviewed May 20, 2022
View reviewed changes
cloud/scope/cluster.go Show resolved Hide resolved
cloud/scope/machine_pool.go Show resolved Hide resolved
cloud/scope/machine_pool.go Show resolved Hide resolved
@joekr joekr merged commit cbb0954 into oracle:main May 20, 2022
This was referenced May 20, 2022
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyamradhakrishnan shyamradhakrishnan shyamradhakrishnan approved these changes

@arindam-bandyopadhyay arindam-bandyopadhyay Awaiting requested review from arindam-bandyopadhyay

Assignees

@joekr joekr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for MachinePool
2 participants
@joekr @shyamradhakrishnan