Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 7.4 and 8.0snapshot for travis CI build #30

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Nov 30, 2020

No description provided.

@smoench smoench mentioned this pull request Nov 30, 2020
5 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.615% when pulling 416397a on smoench:patch-1 into 1493114 on oradwell:master.

@oradwell
Copy link
Owner

thanks for this PR. Nice and clean!

@oradwell oradwell merged commit a238ae1 into oradwell:master Nov 30, 2020
@smoench
Copy link
Contributor Author

smoench commented Nov 30, 2020

@oradwell Currently one test is failing on PHP 8.0 because of:

1) OckCyp\CoversValidator\Tests\Command\ValidateCommandTest::testSkipsEmptyTestClasses
preg_match(): Compilation failed: PCRE2 does not support \F, \L, \l, \N{name}, \U, or \u at offset 9
/home/travis/build/oradwell/covers-validator/tests/BaseTestCase.php:35
/home/travis/build/oradwell/covers-validator/tests/Command/ValidateCommandTest.php:186

Travis integration seems to be broken and the migration to travis-ci.com is needed.

@oradwell
Copy link
Owner

@smoench I'll sort all out once the tests complete

@smoench smoench deleted the patch-1 branch November 30, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants