fix: make check always compiles dependencies #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make is supposed to only compile dependencies when they change but `make check` always compiles them, making the test suite run slow. ``` $ make check cc ... build/mpc.o $ make check cc ... build/mpc.o ``` The same occurs for other targets like `build/test-dynamic` and `build/test-static`. This happens because these targets have the `$(DIST)` directory as a dependency, and directories always change whenever members are added, removed or renamed. Fix this by changing the `$(DIST)` directory dependency to a `$(DIST)/.dirstamp` file. Now `make check` compiles dependencies only once.
|
Yeah, that's my fault. I tend to solve this a different way these days, but I like your fix better than completely changing the mechanism. Concept ACK. Will test locally. |
HalosGhost
requested changes
Aug 4, 2023
HalosGhost
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Make is supposed to only compile dependencies when they change but
make checkalways compiles them, making the test suite run slow.The same occurs for other targets like
build/test-dynamicandbuild/test-static.This happens because these targets have the
$(DIST)directory as a dependency, and directories always change whenever members are added, removed or renamed.See https://stackoverflow.com/a/4445262/4692662
Solution
Fix this by changing the
$(DIST)directory dependency to a$(DIST)/.dirstampfile.Now
make checkcompiles dependencies only once.