Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make check always compiles dependencies #164

Merged
merged 3 commits into from
Aug 4, 2023

Commits on Aug 3, 2023

  1. fix: make check always compiles dependencies

    Make is supposed to only compile dependencies when they change but
    `make check` always compiles them, making the test suite run slow.
    
    ```
    $ make check
    cc ... build/mpc.o
    
    $ make check
    cc ... build/mpc.o
    ```
    
    The same occurs for other targets like `build/test-dynamic` and
    `build/test-static`.
    
    This happens because these targets have the `$(DIST)` directory as a
    dependency, and directories always change whenever members are added,
    removed or renamed.
    
    Fix this by changing the `$(DIST)` directory dependency to a
    `$(DIST)/.dirstamp` file.
    
    Now `make check` compiles dependencies only once.
    steve-chavez committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    1523a83 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. remove tags

    steve-chavez committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    c2feb36 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    57ce9be View commit details
    Browse the repository at this point in the history