-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add subproject owners to a central place #30
Conversation
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to get CNCF unblocked.
That said, as noted in some of the other ORAS and Notary PRs, the relationship between CODEOWNERS
, MAINTAINERS
, GitHub Teams, Org and now this SUBPROJECT_OWNERS
file is quite confusing.
I believe CNCF is looking for a consolidated list to point to, as noted above. This does serve the purpose, so LGTM. I just wonder how these files will stay maintained, over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@SteveLasker Thanks for the heads up. You are correct. CNCF just requires a consolidated maintainer list as a reference. It requires additional efforts to maintain it indeed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should discuss this a bit more. Having 3 owner related files makes it really hard to understanding. Maybe add comments to each or collapse them and create an ORG repo for CNCF related operations.
Can we place the relationship of the multiple files in the governance docs? |
Based on our weekly meeting, I've added #36 to supersede this PR. |
@FeynmanZhou, can we close this, and review/merge #36? |
Fix #23 also one item of https://github.com/oras-project/community/issues/28].
If this PR is approved and merged, we will sync it to the CNCF maintainer list.