-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sub-Project clarification #36
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to also update the README.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but that could be a separate PR
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| - | - | - | | ||
| Org Governance | [governance](https://github.com/oras-project/community) | [CODEOWNERS](https://github.com/oras-project/community/blob/main/CODEOWNERS) | | ||
| [oras.land](https://oras.land) website content | [oras-www](https://github.com/oras-project/oras-www) | [CODEOWNERS](https://github.com/oras-project/oras-www/blob/main/CODEOWNERS) | | ||
| oras go client | [oras](https://github.com/oras-project/oras)<br>[oras-go](https://github.com/oras-project/oras-go)<br>[setup-oras](https://github.com/oras-project/setup-oras)<br>[oras-credentials-go](https://github.com/oras-project/oras-credentials-go) | [CODEOWNERS](https://github.com/oras-project/oras/blob/main/CODEOWNERS) <br>[CODEOWNERS](https://github.com/oras-project/oras-go/blob/main/CODEOWNERS)<br>[CODEOWNERS](https://github.com/oras-project/setup-oras/blob/main/CODEOWNERS) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SteveLasker Is it better to differentiate CLI and library for ORAS? It's a bit strange to put oras in the oras go client sub-project. Shall we create a new row ORAS CLI
and move oras accordingly?
@@ -0,0 +1,13 @@ | |||
# ORAS Sub-Projects | |||
|
|||
The ORAS Project represents the following sub-projects: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to clarify the definition differences between sub-project and repository? This doc indicates that the sub-project is one or a group of repositories in the same category.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
Adds
/sub-projects.md
to clarify the list of sub-projects and the associated owners.Fixes #23
FWIW, the line wrapping within the table is not easy to view in markdown editing mode, but viewing in preview mode makes it more clear.
Personally, I prefer the table view for end-user view. But, if folks would prefer a better editing experience, we could switch this to a bulleted list. Although, the mapping between multiple repos and owners would be difficult.