Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the testing for the GPU backend #4345

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

anagainaru
Copy link
Contributor

Adding Kokkos and updating CUDA for the latest changes.

@anagainaru
Copy link
Contributor Author

I am in favor of removing the CUDA testing. It's more code to take care of and we are only testing that the CUDA function does the same as Kokkos (I am splitting between them down the line so we don't need to check high level functionality).

And anyway no CI is triggering CUDA testing anyway so there is no point in keeping it.

@anagainaru anagainaru force-pushed the kokkos-testing branch 4 times, most recently from aef104c to 3dcfb31 Compare September 15, 2024 21:45
@vicentebolea
Copy link
Collaborator

Note that we have build coverage in CI for CUDA. This has some value by itself. Also we might be able to get a CUDA runner later on through the Spack CI.

@anagainaru
Copy link
Contributor Author

anagainaru commented Sep 16, 2024

I'm all for testing, but right now we are not trigger it anywhere and it's just code that needs to be maintained. The CUDA tests would not pass right now because we changed the way the backend is used but nobody noticed because we are not triggering it. I'll add it back once we decide to trigger the testing. At least the Kokkos one I can run from time to time on Frontier.

Note that we have build coverage in CI for CUDA. This has some value by itself. Also we might be able to get a CUDA runner later on through the Spack CI.

@anagainaru anagainaru merged commit cae0a45 into ornladios:master Sep 22, 2024
37 checks passed
@anagainaru anagainaru deleted the kokkos-testing branch September 22, 2024 02:18
@vicentebolea
Copy link
Collaborator

vicentebolea commented Oct 3, 2024

This change added regressions at master https://open.cdash.org/builds/9940686

@vicentebolea
Copy link
Collaborator

We missed this because the frontier CI was unavailable for a few weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants