Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Updating the testing for the GPU backend" #4357

Closed
wants to merge 1 commit into from
Closed

Revert "Updating the testing for the GPU backend" #4357

wants to merge 1 commit into from

Conversation

vicentebolea
Copy link
Collaborator

Reverts #4345

anagainaru
anagainaru requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@anagainaru anagainaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not revert it, the testing was broken before. I ran it on Frontier and it was fine, let me reproduce this and fix it. If I can't I will completely remove it but not revert to what was before

@anagainaru anagainaru mentioned this pull request Oct 7, 2024
Closed
@anagainaru
Copy link
Contributor

Fixed in #4358

@anagainaru anagainaru closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anagainaru anagainaru anagainaru requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicentebolea @anagainaru