Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarify documentation on code strategy payloads #3228

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Apr 12, 2023
@jonas-jonas jonas-jonas changed the title chore: clarift documentation on code strategy payloads chore: clarify documentation on code strategy payloads Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #3228 (fa5d15b) into master (52f0740) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head fa5d15b differs from pull request most recent head 389cee0. Consider uploading reports for the commit 389cee0 to get more accurate results

@@            Coverage Diff             @@
##           master    #3228      +/-   ##
==========================================
- Coverage   77.94%   77.92%   -0.03%     
==========================================
  Files         319      319              
  Lines       20431    20431              
==========================================
- Hits        15925    15920       -5     
- Misses       3310     3312       +2     
- Partials     1196     1199       +3     
Impacted Files Coverage Δ
selfservice/flow/recovery/strategy.go 100.00% <ø> (ø)
selfservice/flow/verification/strategy.go 75.00% <ø> (ø)
selfservice/strategy/code/strategy_recovery.go 70.56% <100.00%> (ø)
selfservice/strategy/code/strategy_verification.go 74.25% <100.00%> (ø)
selfservice/strategy/link/strategy_recovery.go 63.33% <100.00%> (ø)
selfservice/strategy/link/strategy_verification.go 62.74% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit c15de85 into master Apr 13, 2023
@aeneasr aeneasr deleted the jonas-jonas/clarifyCodeDocs branch April 13, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants