Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(oidc): grace period for continuity container on oidc callbacks #3915

Merged
merged 3 commits into from
May 17, 2024

chore: synchronize workspaces

926ed2a
Select commit
Loading
Failed to load commit list.
Merged

fix(oidc): grace period for continuity container on oidc callbacks #3915

chore: synchronize workspaces
926ed2a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 17, 2024 in 0s

78.08% (target 70.00%)

View this Pull Request on Codecov

78.08% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 66.07143% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 78.08%. Comparing base (5288bc7) to head (926ed2a).
Report is 1 commits behind head on master.

Files Patch % Lines
continuity/manager_cookie.go 40.00% 5 Missing and 4 partials ⚠️
x/cookie.go 0.00% 6 Missing ⚠️
persistence/sql/persister_continuity.go 75.00% 1 Missing and 2 partials ⚠️
selfservice/strategy/oidc/strategy.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3915      +/-   ##
==========================================
+ Coverage   78.02%   78.08%   +0.05%     
==========================================
  Files         362      362              
  Lines       25296    25341      +45     
==========================================
+ Hits        19737    19787      +50     
+ Misses       4047     4038       -9     
- Partials     1512     1516       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov