Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anaconda: container installer #322

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

supakeen
Copy link
Member

@supakeen supakeen commented Dec 14, 2023

Based on: #315

This introduces a new image that installs a bootc bootable container with Anaconda.

@supakeen supakeen marked this pull request as ready for review December 15, 2023 10:30
@supakeen supakeen force-pushed the container-installer branch 2 times, most recently from 1360666 to 56146ec Compare December 15, 2023 13:23
@supakeen supakeen force-pushed the container-installer branch 3 times, most recently from ffabbd4 to 6dedab4 Compare December 20, 2023 12:41
@supakeen supakeen changed the title Container installer anaconda: container installer Dec 20, 2023
@supakeen supakeen force-pushed the container-installer branch 8 times, most recently from 555ac1d to fb1e03a Compare December 20, 2023 14:09
pkg/manifest/anaconda_installer_iso_tree.go Outdated Show resolved Hide resolved
pkg/manifest/anaconda_installer_iso_tree.go Outdated Show resolved Hide resolved
pkg/manifest/anaconda_installer_iso_tree.go Show resolved Hide resolved
pkg/manifest/anaconda_installer_iso_tree.go Outdated Show resolved Hide resolved
pkg/manifest/anaconda_installer_iso_tree.go Outdated Show resolved Hide resolved
pkg/manifest/anaconda_installer_iso_tree.go Show resolved Hide resolved
@supakeen supakeen force-pushed the container-installer branch 7 times, most recently from fa2fc97 to 72ef7e3 Compare December 21, 2023 14:07
@supakeen supakeen force-pushed the container-installer branch 4 times, most recently from 0da8806 to 9d6c8ff Compare December 21, 2023 14:25
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tiny comment about the commit history though.

pkg/manifest/anaconda_installer_iso_tree.go Outdated Show resolved Hide resolved
A new image type that will use Anaconda to install a container to a
filesystem unattended. This initial commit introduces the image without
actually making the install unattended, just a bootable ISO.
Use a fixed kickstart to cut corners, this needs a PoC as soon as
possible.

We need manual partitioning because we need to set the boot label on the
`/boot` partition. It is possible that this won't be necessary in the
future: rhinstaller/anaconda#5363

We'll remove the kickstart literal once the PR is merged and the options
used are merged into the kickstart stage.
Let's do what we *can* do with the kickstart stage and leave the options
that are not yet supported in a custom kickstart file. I'll then
transfer the options into the kickstart stage.
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@achilleas-k achilleas-k added this pull request to the merge queue Jan 5, 2024
Merged via the queue into osbuild:main with commit 9d0e9e5 Jan 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants