-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anaconda: container installer #322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b9511d
to
ab2e274
Compare
supakeen
commented
Dec 14, 2023
ab2e274
to
3df062d
Compare
achilleas-k
reviewed
Dec 15, 2023
1360666
to
56146ec
Compare
ffabbd4
to
6dedab4
Compare
555ac1d
to
fb1e03a
Compare
achilleas-k
requested changes
Dec 21, 2023
fa2fc97
to
72ef7e3
Compare
0da8806
to
9d6c8ff
Compare
achilleas-k
reviewed
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tiny comment about the commit history though.
A new image type that will use Anaconda to install a container to a filesystem unattended. This initial commit introduces the image without actually making the install unattended, just a bootable ISO.
Use a fixed kickstart to cut corners, this needs a PoC as soon as possible. We need manual partitioning because we need to set the boot label on the `/boot` partition. It is possible that this won't be necessary in the future: rhinstaller/anaconda#5363 We'll remove the kickstart literal once the PR is merged and the options used are merged into the kickstart stage.
Let's do what we *can* do with the kickstart stage and leave the options that are not yet supported in a custom kickstart file. I'll then transfer the options into the kickstart stage.
9d6c8ff
to
9dacdc0
Compare
achilleas-k
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: #315
This introduces a new image that installs a bootc bootable container with Anaconda.