iso: be able to build the ISO #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supakeen
force-pushed
the
container-installer
branch
3 times, most recently
from
89bf8d2
to
1c0395e
Compare
5 tasks
ondrejbudai
reviewed
Jan 8, 2024
ondrejbudai
previously requested changes
Jan 9, 2024
|
Wait, will bootupd solve this also for this ISO? I don't expect bootupd to be used there.
I just mean used as far as image construction. Agree it doesn’t make too much sense to have a concept of updating the bootloader of an ISO.
Basically I’m just saying we fixed this papercut for containers and hence when we use containers for the ISO we get this fixed for free.
|
supakeen
force-pushed
the
container-installer
branch
2 times, most recently
from
ffe5624
to
4a9d670
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
@mvo5 thanks, let's try! |
supakeen
force-pushed
the
container-installer
branch
2 times, most recently
from
663541f
to
294743e
Compare
|
@mvo5 I've backed out the smoke test commit until we resolve the issues with the ISO rebooting and how to handle that in the test case(s). |
achilleas-k
requested changes
Jan 10, 2024
This comment was marked as outdated.
This comment was marked as outdated.
supakeen
force-pushed
the
container-installer
branch
2 times, most recently
from
866d8cd
to
fb2c787
Compare
Adds another type which will build an ISO with the container embedded for Anaconda to do the rest.
There is no need to have them separate.
`zstd` compression leads to a faster build.
We'll be removing the `ref` from the constructor(s) in `images` at a later point in time as well.
supakeen
force-pushed
the
container-installer
branch
from
fb2c787
to
502b401
Compare
achilleas-k
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs: osbuild/images#322