-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenSCAP json tailoring (HMS-3826) #798
Add OpenSCAP json tailoring (HMS-3826) #798
Conversation
ac8773d
to
2f611a8
Compare
2f611a8
to
e92bb38
Compare
For context, Sanne and I had a meeting with compliance and the OpenSCAP team. They are trying to hide and abstract away the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good. I've added a few comments... 😉
2124e40
to
2f030f1
Compare
2f030f1
to
d361ab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! ty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks!
Following a meeting with compliance and the OpenSCAP team we decided to implement the json tailoring. They are trying to hide and abstract away the xml tailoring completely for future versions of RHEL and Fedora. So we decided to remove the xml tailoring support - this can easily be added back in if we need it at a later stage
Add a type for json tailoring configs.
We need to create tailoring configs for the json tailoring config type. The autotailor stage will consume the json file and then create an xml tailoring file which is then consumed by the OpenSCAP remediation stage.
Create stage autotailor stage options where the stage consumes a json tailoring file and outputs the `xml` tailored file that will then be consumed by the remediation stage.
Add a test for RHEL9 to check tailoring with a `json` tailoring file.
d361ab7
to
fd7b6e3
Compare
This PR adds the ability to consume an JSON tailoring file.
Depends on: osbuild/osbuild#1794