-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenSCAP json tailoring (HMS-3827) #4272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingsleyzissou
force-pushed
the
oscap-json-tailoring
branch
from
August 6, 2024 10:29
a3958b9
to
842a2c6
Compare
croissanne
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but one question about the go.mod changes.
kingsleyzissou
force-pushed
the
oscap-json-tailoring
branch
2 times, most recently
from
August 6, 2024 14:21
75db4cd
to
8d07b99
Compare
Add an initial test for OpenSCAP tailoring customizations since we will be expanding the tailoring options to support json tailoring.
Add support to the blueprints for json tailoring files
Add support for json tailoring files in the cloudapi. Expand the tests to check that the options returned are okay and that tailoring options and json tailoring options can't be provided at the same time.
kingsleyzissou
force-pushed
the
oscap-json-tailoring
branch
from
August 6, 2024 14:52
8d07b99
to
424390f
Compare
croissanne
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
thozza
added a commit
to thozza/osbuild-composer
that referenced
this pull request
Aug 7, 2024
This was forgotten in [1], which depens on [2], which landed in osbuild v120. [1] osbuild#4272 [2] osbuild/osbuild#1777 Signed-off-by: Tomáš Hozza <thozza@redhat.com>
thozza
added a commit
to thozza/osbuild-composer
that referenced
this pull request
Aug 12, 2024
This was forgotten in [1], which depens on [2], which landed in osbuild v120. [1] osbuild#4272 [2] osbuild/osbuild#1777 Signed-off-by: Tomáš Hozza <thozza@redhat.com>
thozza
added a commit
to thozza/osbuild-composer
that referenced
this pull request
Aug 12, 2024
This was forgotten in [1], which depens on [2], which landed in osbuild v120. [1] osbuild#4272 [2] osbuild/osbuild#1777 Signed-off-by: Tomáš Hozza <thozza@redhat.com>
thozza
added a commit
to thozza/osbuild-composer
that referenced
this pull request
Aug 12, 2024
This was forgotten in [1], which depens on [2], which landed in osbuild v120. [1] osbuild#4272 [2] osbuild/osbuild#1777 Signed-off-by: Tomáš Hozza <thozza@redhat.com>
thozza
added a commit
that referenced
this pull request
Aug 13, 2024
This was forgotten in [1], which depens on [2], which landed in osbuild v120. [1] #4272 [2] osbuild/osbuild#1777 Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes:
Depends on: osbuild/images#798