templates/openshift: split worker from composer maintenance #4102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep a symlink to the old composer template so the current deployment doesn't break.
croissanne
force-pushed
the
maintenance-split
branch
from
20e0bbb
to
b368628
Compare
|
Can't really "test" but looks sane |
schuellerf
previously approved these changes
Apr 24, 2024
croissanne
force-pushed
the
maintenance-split
branch
from
b368628
to
b8b1d46
Compare
schuellerf
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for this split is that we can start scheduling maintenance jobs per tenant we have in app-intf. Currently the composer maintenance job also maintains the cloud accounts for the CRC tenant, while composer should be tenant-agnostic. The composer maintenance job should just maintain the DB, and then the specific worker maintenance job should maintain the worker resources.
As soon as this is split, we can start deploying it and disabling the aws/gcp maintenance in the composer namespace, as well as expanding the aws maintenance to look for leftover resources related to the worker-executor stuff.