Makefile for templates/openshift #4103
Conversation
There was a problem hiding this comment.
Hmm I wonder if this makes sense to put in the makefile. The only reason we process them in the github workflow is so that kubelinter can do a very basic check. The processing of the template when actually deploying is something that is out of our hands. If we put it in the makefile, then i'd just consider it as a helper for the github workflow.
|
We could use it from GitHub Workflow but I just wanted to call it so see if there are syntax problems locally (avoid GitHub Action problems before pushing - the usual problem) |
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
I like having the ability to run things from the Makefile. I'd also add a commit that converts the workflow to use the Makefile target so that things don't drift. |
schuellerf
force-pushed
the
makefile_for_pr_4102
branch
from
d0cff35
to
a228c47
Compare
schuellerf
force-pushed
the
makefile_for_pr_4102
branch
from
a228c47
to
1132401
Compare
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
schuellerf
force-pushed
the
makefile_for_pr_4102
branch
from
1132401
to
0bbe7a0
Compare
just for manual checks if the template syntax is fine and align with the github action to use the same code
schuellerf
force-pushed
the
makefile_for_pr_4102
branch
from
0bbe7a0
to
05eb65a
Compare
I just wanted to check #4102 locally.
maybe that's helpful for someone