cache automorphism groups of number fields

[fieker]

and related:

• aut grp local fields
• IdelClassGmodule
• allow for use of lll-order by changeing ideal parents
• galois group via cohomolgy: make sure the rcf is normal

[codecov]

Codecov Report

Merging #2436 (948a485) into master (a94bc0e) will decrease coverage by 0.04%.
The diff coverage is 40.81%.

❗ Current head 948a485 differs from pull request most recent head 6019f1a. Consider uploading reports for the commit 6019f1a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2436      +/-   ##
==========================================
- Coverage   71.62%   71.59%   -0.04%     
==========================================
  Files         395      393       -2     
  Lines       53023    52905     -118     
==========================================
- Hits        37979    37877     -102     
+ Misses      15044    15028      -16     

Impacted Files	Coverage Δ
experimental/GModule/GaloisCohomology.jl	9.50% <40.81%> (+1.40%)	⬆️

... and 20 files with indirect coverage changes

[fingolfin]

Fine by me, though I note that none of the new code is exercised by any tests -- because almost none of the existing code in this file has code coverage

Since this is in experimental, that's OK, though I note that a few simple tests would help prevent us from accidentally breaking this code

[thofma]

Hm, why (PermGroup,) and not just PermGroup as the key?

[fieker]

On Fri, Jun 02, 2023 at 04:06:47AM -0700, Tommy Hofmann wrote: Hm, why `(PermGroup,)` and not just `PermGroup` as the key?

So it's a tuple either PermGroup, of length 1 or PermGroup, field of length 2 if one needs a relative aut grup

…

-- Reply to this email directly or view it on GitHub: #2436 (comment) You are receiving this because you authored the thread. Message ID: ***@***.***>