Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add absolute_automorphism_group(::Type{PermGroup}, ...) #2458

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Add absolute_automorphism_group(::Type{PermGroup}, ...) #2458

merged 1 commit into from
Aug 2, 2023

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented Jun 9, 2023

No description provided.

@thofma thofma requested a review from fieker June 9, 2023 20:44
@codecov
Copy link

codecov bot commented Jun 9, 2023 •
edited
Loading

Codecov Report

Merging #2458 (5232c62) into master (a4d4948) will increase coverage by 0.96%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 5232c62 differs from pull request most recent head 90f0e78. Consider uploading reports for the commit 90f0e78 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2458      +/-   ##
==========================================
+ Coverage   72.10%   73.07%   +0.96%     
==========================================
  Files         429      396      -33     
  Lines       60508    53219    -7289     
==========================================
- Hits        43632    38888    -4744     
+ Misses      16876    14331    -2545
Files Changed Coverage Δ
experimental/GModule/GaloisCohomology.jl 62.23% <100.00%> (-0.18%) ⬇️

... and 220 files with indirect coverage changes

fieker
fieker reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@fieker fieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to the caching introduced in #2436?

@thofma thofma force-pushed the th/autgrp branch 2 times, most recently from 1a134fe to 753af27 Compare July 30, 2023 15:07
fieker
fieker approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@fieker fieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll have to sort out the caching, but I'd suggest to do this independently

@fieker
Copy link
Contributor

fieker commented Jul 31, 2023

There is (?) a missing elem_type for sets of morphisms?

@thofma
Copy link
Collaborator Author

thofma commented Jul 31, 2023

Yes, I am on it.

@thofma thofma merged commit 995942d into master Aug 2, 2023
7 of 12 checks passed
@thofma thofma deleted the th/autgrp branch August 2, 2023 05:09
wdecker pushed a commit that referenced this pull request Aug 4, 2023
@thofma @wdecker
Add absolute_automorphism_group(::Type{PermGroup}, ...) (#2458)
d29d68d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fieker fieker fieker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thofma @fieker