Change is_skewsymmetric_matrix to is_alternating
#2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
commented
Jul 17, 2023
lgoettgens
force-pushed
the
lg/is_skewsymmetric_matrix
branch
from
d260a8e
to
014f57e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2566 +/- ##
==========================================
- Coverage 72.82% 71.88% -0.95%
==========================================
Files 416 417 +1
Lines 55587 57320 +1733
==========================================
+ Hits 40482 41204 +722
- Misses 15105 16116 +1011
|
fingolfin
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2555.
I renamed
is_skewsymmetric_matrixtois_alternating, and updated all uses accordingly. In one test, there was a natural place to test that this indeed differs fromis_skew_symmetricin characteristic 2.