Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports Oscar 1.0 #3429

Merged
merged 30 commits into from
Feb 29, 2024
Merged

Backports Oscar 1.0 #3429

merged 30 commits into from
Feb 29, 2024

Commits on Feb 26, 2024

  1. Add QQBar docs to the manual (#3423)

    * Add QQBar docs to the manual
    
    * Update field overview list
    
    (cherry picked from commit 7164435)
    lgoettgens authored and benlorenz committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    427cbe9 View commit details
    Browse the repository at this point in the history
  2. do not show the OscarInterface banner

    (cherry picked from commit 5f86803)
    ThomasBreuer authored and benlorenz committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    ab83c3b View commit details
    Browse the repository at this point in the history
  3. fix bugs in all_OD_infos (#3419)

    * fix bugs in `all_OD_infos`
    
    * added a test
    
    (cherry picked from commit 3672388)
    ThomasBreuer authored and benlorenz committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    69eed70 View commit details
    Browse the repository at this point in the history
  4. Rename Spec to AffineScheme #3345 (#3425)

    * Rename Spec -> AffineScheme
    
    Use `AffineScheme` only for the type, not the function.
    
    * Rename proj for toric divisors to projectivization
    
    As was recommended by Martin Bies and Wolfram Decker.
    
    * Function ProjectiveScheme to projective_scheme and proj
    
    * Fix: spec now extends the constructor AffineScheme
    
    In particular, spec allows the argument to be a quotient ring or localized ring. Similarly for proj. Probably the tests would not have passed in the previous commit because of this
    
    * add support for projective_scheme and affine_scheme
    
    ---------
    
    Co-authored-by: Simon Brandhorst <brandhorst@math.uni-sb.de>
    (cherry picked from commit b00d5e4)
    paemurru authored and benlorenz committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    82d40ff View commit details
    Browse the repository at this point in the history
  5. Remove two mentions of Arb_jll (#3431)

    (cherry picked from commit 8afc6a8)
    lgoettgens authored and benlorenz committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    8b5f116 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Tweak epimorphism_from_free_group (#3430)

    ... to ensure rank of the free group is set.
    
    (cherry picked from commit 4cea177)
    fingolfin authored and benlorenz committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    633ab20 View commit details
    Browse the repository at this point in the history
  2. Add all_perfect_groups (#3434)

    (cherry picked from commit 6308dd7)
    fingolfin authored and benlorenz committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    1a621a1 View commit details
    Browse the repository at this point in the history
  3. Add all_primitive_groups and all_transitive_groups variants takin…

    …g a single int or int range (#3404)
    
    (cherry picked from commit 83f0575)
    lgoettgens authored and benlorenz committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    62e71ad View commit details
    Browse the repository at this point in the history
  4. Align all_*_groups methods some more (#3433)

    For `all_small_groups` we allow specifying the order as a single
    integer or abstract vector, followed by any number of additional
    filters. For transitive and primitive groups, we also allowed
    specifying the degree as a single integer or abstract vector, but
    this then could not be followed by filters. With this patch the
    additional filters work in all cases.
    
    (cherry picked from commit dd7913b)
    fingolfin authored and benlorenz committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8efba73 View commit details
    Browse the repository at this point in the history
  5. support gen(G::GAPGroup, 0) (#3332)

    * support `gen(G::GAPGroup, 0)`
    
    This was already supported for `FinGenAbGroup`.
    
    (The delegations between methods are not the same:
    For `FinGenAbGroup`, there is special code for `getindex(A, i)`,
    and `gen(A, i)` calls `getindes(A, i)`.
    For `GAPGroup`, there is special code for `gen(G, i)`,
    and the generic `getindex` method from AbstractAlgebra calls `gen(G, i)`.)
    
    * support negative indices, meaning inverses
    
    (cherry picked from commit 58566cc)
    ThomasBreuer authored and benlorenz committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    6e1af55 View commit details
    Browse the repository at this point in the history
  6. CI: re-enable nightly (#3435)

    (cherry picked from commit bb7fe08)
    benlorenz committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    28e5dab View commit details
    Browse the repository at this point in the history
  7. fix a docstring (#3436)

    (cherry picked from commit 52a2a88)
    ThomasBreuer authored and benlorenz committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    b7a68b7 View commit details
    Browse the repository at this point in the history
  8. Fixes multivariate division (#3396)

    * uses new divrem from Singular, fits Singular's reduce
    
    * adds test case from issue #3105
    
    * bump Singular to v0.22.4 for divrem2
    
    * fixes doctests
    
    (cherry picked from commit 2cc5013)
    ederc authored and benlorenz committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    78cfbc1 View commit details
    Browse the repository at this point in the history
  9. Docu invariants tori (#3428)

    * Add test example to PR #3412 as requested by @thofma
    
    * docu invariants tori
    
    * readd algebraic.md
    
    * typo
    
    * Update docs/doc.main
    
    * add one more functions and corrections
    
    * correction
    
    * correction
    
    * addressing review
    
    * forgot to add corrected file
    
    ---------
    
    Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
    (cherry picked from commit 3c5f7fe)
    wdecker authored and benlorenz committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    0a84f77 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Bugfix for printing of affine schemes (#3437)

    * Fix printing of of affine schemes.
    
    (cherry picked from commit 2a87512)
    HechtiDerLachs authored and benlorenz committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1bcfe91 View commit details
    Browse the repository at this point in the history
  2. Improve docstrings for is_conjugate/is_conjugate_with_data. (#3384)

    (cherry picked from commit 95a1e27)
    mjrodgers authored and benlorenz committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b4bb046 View commit details
    Browse the repository at this point in the history
  3. Bugfix for bugfix for printing of affine schemes (#3445)

    (cherry picked from commit 62d3c12)
    thofma authored and benlorenz committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    9bcd119 View commit details
    Browse the repository at this point in the history
  4. Fix ambient_module(M::SubquoModule) (#3448)

    (cherry picked from commit 318a2c5)
    fingolfin authored and benlorenz committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    64177dc View commit details
    Browse the repository at this point in the history
  5. Update OSCAR banner (#3410)

    ---------
    
    Co-authored-by: Max Horn <max@quendi.de>
    Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
    (cherry picked from commit f468cca)
    paemurru authored and benlorenz committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    79bc563 View commit details
    Browse the repository at this point in the history
  6. support group properties for character tables (#3449)

    and character value access by class names
    
    (cherry picked from commit e86fe09)
    ThomasBreuer authored and benlorenz committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    4139960 View commit details
    Browse the repository at this point in the history
  7. Unexport normalise (#3453)

    (cherry picked from commit e45ff24)
    lgoettgens authored and benlorenz committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b5da7dd View commit details
    Browse the repository at this point in the history
  8. add od_from_atlas_group, od_from_p_subgroup, and helpers (#3444)

    * add `conductor` for class functions
    
    * add `:constituents` key (if available)
    
    to the dictionaries returned by `all_atlas_group_infos`
    
    * support `min_char` in `isomorphic_group_over_finite_field`
    
    i.e., prescribe a minimal characteristic for the returned group,
    in order to guarantee that the reduction of an irreducible group
    is also irreducible
    
    * better handling of quadratic fields
    
    - improve coercion from quadratic fields into `QQAbField`;
      the check for `is_quadratic_field` is not general enough,
      and evaluation of a field element requires not just some polynomial ring
      but the underlying polynomial ring of the number field
    - and add `_embedding` of `QQ` into `QQAbField`, for convenience
    
    * added `orbits_group_automorphisms` and helpers
    
    * add `od_from_atlas_group` and helper
    
    * add p-group criterion
    
    - add `known_class_fusions`
    - add optional argument to `induced_cyclic`
    - add `od_from_p_subgroup`
    - add helper `possible_permutation_characters_from_sylow_subgroup`
    
    * adjust to the changes in Oscar since November
    
    * now the tests pass again
    
    * `FiniteField` does no longer exist
    
    * use `number_of_conjugacy_classes`
    
    * omit some tests that require AtlasRep at least 2.1.7
    
    * for the moment, leave out tests that need web access
    
    (cherry picked from commit 556be5a)
    ThomasBreuer authored and benlorenz committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    5223042 View commit details
    Browse the repository at this point in the history
  9. Docu invariants lin. red. groups (Lakshmi Ramesh and Wolfram Decker) (#…

    …3443)
    
    Co-authored-by: Johannes Schmitt <schmitt@mathematik.uni-kl.de>
    (cherry picked from commit 73ba787)
    wdecker authored and benlorenz committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d4e9082 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. add docstrings for acting_group and action_function (#3432)

    (cherry picked from commit c58c7eb)
    mjrodgers authored and aaruni96 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    27876bb View commit details
    Browse the repository at this point in the history
  2. Ensure fp_group(G) transfers group attributes (#3464)

    (cherry picked from commit 0e19721)
    fingolfin authored and benlorenz committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    193a4a5 View commit details
    Browse the repository at this point in the history
  3. Export weierstrass_chart_on_minimal_model and patch transform_to_weie…

    …rstrass (#3458)
    
    * Export weierstrass_chart_on_minimal_model.
    
    * Repair transform_to_weierstrass.
    
    (cherry picked from commit 1a8e8e3)
    HechtiDerLachs authored and benlorenz committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    38dc74a View commit details
    Browse the repository at this point in the history
  4. Fix a doc signature (#3466)

    (cherry picked from commit 189a55f)
    joschmitt authored and benlorenz committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    1a8d627 View commit details
    Browse the repository at this point in the history
  5. Added comment on convention (#3467)

    * Added comment on convention
    
    * Update experimental/InvariantTheory/src/InvariantTheory.jl
    
    Co-authored-by: Johannes Schmitt <schmitt@mathematik.uni-kl.de>
    
    ---------
    
    Co-authored-by: Johannes Schmitt <schmitt@mathematik.uni-kl.de>
    (cherry picked from commit 21d13c9)
    wdecker authored and benlorenz committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    dee8a25 View commit details
    Browse the repository at this point in the history
  6. Adjust to renaming of rank(A::FinGenAbGroup) to `torsion_free_rank(…

    …A::FinGenAbGroup)` (#3457)
    
    * Prepare for renaming of rank(A::FinGenAbGroup)
    
    ... to torsion_free_rank(A::FinGenAbGroup), see also
    <thofma/Hecke.jl#1224>.
    
    * Use is_z_graded in _regularity_bound
    
    * more rank -> torsion_free_rank
    
    * more
    
    * more more
    
    * Update experimental/GModule/Cohomology.jl
    
    * more more more
    
    * bump Hecke
    
    ---------
    
    Co-authored-by: Tommy Hofmann <thofma@gmail.com>
    Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
    (cherry picked from commit 8b863ed)
    fingolfin authored and benlorenz committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    70616bb View commit details
    Browse the repository at this point in the history
  7. Grading + caching for affine algebra of torus invariants (#3469)

    * TorGrpInvRing to attributes, added test for affine_algebra for tori
    
    * graded affine algebra ring
    
    * fix to doctest
    
    (cherry picked from commit b6f11d0)
    Lax202 authored and benlorenz committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    deb325f View commit details
    Browse the repository at this point in the history