-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow AbstractVectors as input for initial #4027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most of the changes are unneccessary if you would change the relevant signatures (for groebner_basis
and initial
) to allow w::AbstractVector{...}
instead of w::Vector{...}
.
What is still needed is the tropical_semiring(nu)(...)
, otherwise this leads to some promotion error, but that also happens with Vector{QQFieldElem}
.
Good point, I've updated the pull request. |
8b022d0
to
988b607
Compare
Somewhat related question that I just noticed while looking at the code here: Oscar.jl/src/TropicalGeometry/initial.jl Lines 64 to 70 in 988b607
I don't see the contents of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4027 +/- ##
==========================================
+ Coverage 84.06% 84.56% +0.50%
==========================================
Files 597 597
Lines 82121 82191 +70
==========================================
+ Hits 69036 69507 +471
+ Misses 13085 12684 -401
|
Good catch, I think that part is obsolete and can be safely removed. It was originally intended for the tropical traversal algorithm, but |
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
I think the pull-request is ready to be merged, unless @benlorenz has any further comments. |
* TropicalGeometry: fixes initial issue oscar-system#4025 * TropicalGeometry: allow point_vector as input for initial * TropicalGeometry: removing unused optional perturbation input * Update src/TropicalGeometry/initial.jl Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com> --------- Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Fixes #4025.
Important because functions such as
relative_interior_point
return PointVectors, and points on a tropical variety or in a Groebner complex are primary candidates for weight vectors.