Remove some unreachable code Schemes/ and MPolyQuo.jl
#4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
the
release notes: not needed
lgoettgens
changed the title
ideal_sheaf_of_singular_locusSchemes/ and MPolyQuo.jl
|
Looks good. At the time, we left the code for comparison, in case we would experience any regression. But it is true that we have git for this, actually. Guess I was just too lazy. But it's time to remove these things. Thank you for the work! |
HechtiDerLachs
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return statement right above the first removed piece of code got added in #3672 by @HechtiDerLachs.
The return statement right above the second removed piece of code got added in #3609 by @HechtiDerLachs.
Removing this code has no semantic changes whatsoever.