Simplify attribute handling using new @attr features
#4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
WIP
|
Looks reasonable to me. Let's see how the tests go, when they run. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Nemocas/AbstractAlgebra.jl#1958 for the changes to
@attr. This PR needs to wait for Nemocas/AbstractAlgebra.jl#1958 to get released (x-ref Nemocas/AbstractAlgebra.jl#1963).Furthermore, this includes #4475. Depending on the result there, this PR may need to get adapted.
This is a draft, since I want to look through all uses of other attribute-related functions like
get_attributeandset_attribute!as well and do analogous changes for these as well.The diff view may be a bit overwhelming and doesn't make much sense for this kind of change; instead you could look at the diff view with whitespace changes ignored: https://github.com/oscar-system/Oscar.jl/pull/4476/files?w=1
pinging some people that may benefit from this PR: @HereAround @simonbrandhorst @HechtiDerLachs