Fix some bugs since v3.2.10 #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v3.2.10 heavily refactors the parsing of the theme, replacing the Drawable type of plain-color-only graphics / rects with ColorDrawable instead of GradientDrawable, in order to reduce the performance loss. However, that is just my wishful thinking, as there is no conclusive evidence show that that way can do so here. ColorDrawable is a simple Drawable type, which is basically just for showing a plain color shape, but without round corner setting. So let us go back to GradientDrawable.
Update QQ group 2 join code and link.
... to determine whether to redeploy the theme. (osfans#901, osfans#902)
Closed
…id keyboard (osfans#869) - Also reimplement how to save symbol key history (easier).
... to help parse yaml on Java (Kotlin) side version 0.49.0
|
这个版本，点击输入框，都会进入数字键盘模式，而不是字母键盘模式 |
|
@tao659 我这里未能复现 |
|
最新更新的版本https://github.com/osfans/trime/actions/runs/3872195547 |
|
@tao659 可我这里什么事情都没有 …… 我甚至为了测试都卸载重装过一轮了 🤣 |
|
@Bambooin I think here are all the bugs I can fix this time. Ready for review. |
WhiredPlanck
force-pushed
the
3.2.10-fix
branch
from
ca0f87b to
4067fbc
Compare
- Add preference to enable/disable to use custom sound theme (package) - Utilize kaml library to parse sound theme configurations - Ship stuffs of parsing the configurations to SoundManager - Ship stuffs of playing the custom key effect to InputFeedbackManager
- Suppress unchecked casts - Eliminate implicit casts - Remove redundant parameters
WhiredPlanck
force-pushed
the
3.2.10-fix
branch
from
4067fbc to
6ce3631
Compare
最新的pr 已经解决了无法弹出键盘的问题👍🏻 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
trime.custom.yaml失效 #902 )Feature
update social media information:
update the join code and api link of QQ group 2, since the original group has been dismissed for some reasons.
Code of conduct
Gradle task
Tasks passed on every commit
./gradlew spotlessCheck./gradlew assembleDebugManual test
Code Review
Daily build
Login to fetch artifact
https://github.com/osfans/trime/actions
Additional Info