Fix street name localization #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a street somewhere localized in English and German we can use as a test case? 😂 |
|
Yes, see #578 (comment). |
ZeLonewolf
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Looks good to me.
Let's leave #618 open to track that we need to get proper language support added to OMT for other languages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decoupled the
text-fieldexpression oftransportation_namelayers from other layers, since the available fields differ. The broader problem is that we’re overrelying on constants everywhere, but a deeper copy avoids the immediate issue that changing other layers’ localization to use, e.g.,name:deoverwrites any localization toname_dethat has already taken place on this layer./ref #618