Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support send and recv msg size for gRPC #170

Merged
merged 6 commits into from
Apr 4, 2022

Conversation

alexanderbez
Copy link
Collaborator

Description

Update the gRPC configuration to support providing user-provided receive and send max message sizes.

Note, this should be upstreamed to the Cosmos SDK core repo.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez marked this pull request as ready for review April 1, 2022 18:51
server/config/config.go Outdated Show resolved Hide resolved
@alexanderbez
Copy link
Collaborator Author

I have no idea what's up with test-rosetta. I run it locally, and there are absolutely zero logs. There is also no current team maintaining it. I suggest we just remove it all together. Thoughts @ValarDragon?

@alexanderbez alexanderbez merged commit ca48456 into osmosis-main Apr 4, 2022
@alexanderbez alexanderbez deleted the bez/grpc-opts branch April 4, 2022 16:27
mergify bot pushed a commit that referenced this pull request Apr 26, 2022
(cherry picked from commit ca48456)

# Conflicts:
#	server/start.go
czarcas7ic added a commit that referenced this pull request Apr 27, 2022
* feat: support send and recv msg size for gRPC (#170)

(cherry picked from commit ca48456)

# Conflicts:
#	server/start.go

* codec add

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants