Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support send and recv msg size for gRPC (backport #170) #210

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 26, 2022

This is an automatic backport of pull request #170 done by Mergify.
Cherry-pick of ca48456 has failed:

On branch mergify/bp/v0.45.0x-osmo-v7/pr-170
Your branch is up to date with 'origin/v0.45.0x-osmo-v7'.

You are currently cherry-picking commit ca48456f7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   contrib/rosetta/node/data.tar.gz
	modified:   server/config/config.go
	modified:   server/config/toml.go
	modified:   server/grpc/server.go
	modified:   testutil/network/util.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   server/start.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit ca48456)

# Conflicts:
#	server/start.go
@mergify mergify bot requested a review from alexanderbez as a code owner April 26, 2022 23:22
@mergify mergify bot added the conflicts label Apr 26, 2022
@czarcas7ic czarcas7ic self-requested a review April 26, 2022 23:23
@czarcas7ic czarcas7ic merged commit 3fa7fa4 into v0.45.0x-osmo-v7 Apr 27, 2022
@czarcas7ic czarcas7ic deleted the mergify/bp/v0.45.0x-osmo-v7/pr-170 branch April 27, 2022 01:13
@@ -176,6 +176,14 @@ enable = {{ .GRPC.Enable }}
# Address defines the gRPC server address to bind to.
address = "{{ .GRPC.Address }}"

# MaxRecvMsgSize defines the max message size in bytes the server can receive.
# The default value is 4MB.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 10MB

@adizere
Copy link

adizere commented May 3, 2022

FYI: Multiple IBC relayer operators reported problems with the following symptom:

gRPC call failed with status: status: ResourceExhausted, message: "grpc: received message larger than max (26 vs. 0)"

or

relayer error: gRPC call failed with status: status: ResourceExhausted, message: "grpc: received message larger than max (14 vs. 0)"

Note the 0 value. Is it possible that the default for some of these values here is misconfigured to 0?

The fix they used was to add to app.toml of their Osmosis full node

max-recv-msg-size = "10485760"

max-send-msg-size = "2147483647"

@alexanderbez
Copy link

The defaults are defined in server/config/config.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants