Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tokenfactory: cli #1376

Merged
merged 45 commits into from
May 6, 2022
Merged

x/tokenfactory: cli #1376

merged 45 commits into from
May 6, 2022

Conversation

sunnya97
Copy link
Collaborator

Closes: #XXX

What is the purpose of the change

*Add a description of the overall background and high level changes that this PR introduces *

(E.g.: This pull request improves documation of area A by adding ....

Brief change log

(for example:)

  • The metadata is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • Daemons retrieve the RPC data from the blob cache

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added unit test that validates ...
  • Added integration tests for end-to-end deployment with ...
  • Extended integration test for ...
  • Manually verified the change by ...

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@faddat
Copy link
Member

faddat commented Apr 30, 2022

instead of cw20, or in addition to?

@sunnya97
Copy link
Collaborator Author

Tokenfactory is intended to be a replacement for cw20. Instead of using cw20 tokens, CosmWasm contracts on Osmosis can mint/burn native sdk coins

p0mvn
p0mvn previously requested changes May 1, 2022
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Left a few comments, please take a look

x/tokenfactory/client/cli/query.go Show resolved Hide resolved
x/tokenfactory/client/cli/query.go Outdated Show resolved Hide resolved
x/tokenfactory/module.go Outdated Show resolved Hide resolved
x/tokenfactory/module.go Outdated Show resolved Hide resolved
x/tokenfactory/client/cli/tx.go Outdated Show resolved Hide resolved
return cmd
}

// // NewForceTransferCmd broadcast MsgForceTransfer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: what is the plan for this command? When are we planning to enable it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to conduct an audit to make sure that doing a forceTransfer of coins from an account, especially a module account won't cause panics

osmosis-labs/feature-requests#73

sunnya97 and others added 3 commits May 3, 2022 19:33
Co-authored-by: Roman <roman@osmosis.team>
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Roman <roman@osmosis.team>
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #1376 (033bc47) into main (f56fbe5) will decrease coverage by 0.42%.
The diff coverage is 16.39%.

@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
- Coverage   19.82%   19.40%   -0.43%     
==========================================
  Files         202      229      +27     
  Lines       27685    31452    +3767     
==========================================
+ Hits         5489     6102     +613     
- Misses      21175    24237    +3062     
- Partials     1021     1113      +92     
Impacted Files Coverage Δ
x/epochs/client/cli/query.go 0.00% <ø> (ø)
x/gamm/client/cli/query.go 36.74% <0.00%> (-0.36%) ⬇️
x/gamm/pool-models/stableswap/msgs.go 0.00% <0.00%> (ø)
x/gamm/pool-models/stableswap/pool.go 0.00% <0.00%> (ø)
x/gamm/pool-models/stableswap/stableswap_pool.go 0.00% <0.00%> (ø)
.../gamm/pool-models/stableswap/stableswap_pool.pb.go 0.58% <0.00%> (-0.09%) ⬇️
x/gamm/types/pool.go 0.00% <ø> (ø)
x/incentives/client/cli/query.go 0.00% <ø> (ø)
x/incentives/keeper/distribute.go 61.00% <0.00%> (ø)
x/incentives/keeper/hooks.go 50.00% <0.00%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e1c42...033bc47. Read the comment docs.

Base automatically changed from sunny/tokenfactory-logic to main May 5, 2022 05:43
@sunnya97 sunnya97 changed the base branch from main to sunny/tokenfactory-mintfee May 6, 2022 02:36
@sunnya97 sunnya97 requested a review from p0mvn May 6, 2022 02:36
@sunnya97
Copy link
Collaborator Author

sunnya97 commented May 6, 2022

Please merge #1435 first

Base automatically changed from sunny/tokenfactory-mintfee to main May 6, 2022 18:29
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm looking forward to generalized tooling to delete all of this.

All the CLI code is pure boilerplate given a typed go struct lol

@sunnya97
Copy link
Collaborator Author

sunnya97 commented May 6, 2022

Hopefully telescope fixes this

@sunnya97 sunnya97 merged commit 4c4576e into main May 6, 2022
@sunnya97 sunnya97 deleted the sunny/tokenfactory-cli branch May 6, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants