-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tokenfactory: cli #1376
x/tokenfactory: cli #1376
Conversation
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
instead of cw20, or in addition to? |
Tokenfactory is intended to be a replacement for cw20. Instead of using cw20 tokens, CosmWasm contracts on Osmosis can mint/burn native sdk coins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left a few comments, please take a look
return cmd | ||
} | ||
|
||
// // NewForceTransferCmd broadcast MsgForceTransfer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: what is the plan for this command? When are we planning to enable it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to conduct an audit to make sure that doing a forceTransfer of coins from an account, especially a module account won't cause panics
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
00ac63b
to
7204c96
Compare
Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Roman <roman@osmosis.team>
f63a1e0
to
e151d6b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1376 +/- ##
==========================================
- Coverage 19.82% 19.40% -0.43%
==========================================
Files 202 229 +27
Lines 27685 31452 +3767
==========================================
+ Hits 5489 6102 +613
- Misses 21175 24237 +3062
- Partials 1021 1113 +92
Continue to review full report at Codecov.
|
Co-authored-by: Roman <roman@osmosis.team>
Please merge #1435 first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm looking forward to generalized tooling to delete all of this.
All the CLI code is pure boilerplate given a typed go struct lol
Hopefully telescope fixes this |
Closes: #XXX
What is the purpose of the change
*Add a description of the overall background and high level changes that this PR introduces *
(E.g.: This pull request improves documation of area A by adding ....
Brief change log
(for example:)
Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (yes / no)x/<module>/spec/
) / Osmosis docs repo / not documented)