Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tokenfactory create denom fee #1435

Merged
merged 6 commits into from
May 6, 2022
Merged

x/tokenfactory create denom fee #1435

merged 6 commits into from
May 6, 2022

Conversation

sunnya97
Copy link
Collaborator

@sunnya97 sunnya97 commented May 5, 2022

Closes: #1438

What is the purpose of the change

Adds a base fee for creating denoms with x/tokenfactory for spam resistance

Brief change log

Adds a params struct to x/tokenfactory and uses that to store denoms

Testing and Verifying

This change added a check to make sure fees were being paid in tests

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #1435 (201e002) into main (f56fbe5) will decrease coverage by 0.49%.
The diff coverage is 15.75%.

@@            Coverage Diff             @@
##             main    #1435      +/-   ##
==========================================
- Coverage   19.82%   19.32%   -0.50%     
==========================================
  Files         202      229      +27     
  Lines       27685    31405    +3720     
==========================================
+ Hits         5489     6070     +581     
- Misses      21175    24224    +3049     
- Partials     1021     1111      +90     
Impacted Files Coverage Δ
x/epochs/client/cli/query.go 0.00% <ø> (ø)
x/gamm/client/cli/query.go 36.74% <0.00%> (-0.36%) ⬇️
x/gamm/pool-models/stableswap/amm.go 40.27% <0.00%> (-15.50%) ⬇️
x/gamm/pool-models/stableswap/msgs.go 0.00% <0.00%> (ø)
x/gamm/pool-models/stableswap/pool.go 0.00% <0.00%> (ø)
x/gamm/pool-models/stableswap/stableswap_pool.go 0.00% <0.00%> (ø)
.../gamm/pool-models/stableswap/stableswap_pool.pb.go 0.58% <0.00%> (-0.09%) ⬇️
x/gamm/types/pool.go 0.00% <ø> (ø)
x/incentives/client/cli/query.go 0.00% <ø> (ø)
x/incentives/keeper/distribute.go 61.00% <0.00%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddaa866...201e002. Read the comment docs.

@sunnya97 sunnya97 marked this pull request as ready for review May 5, 2022 23:53
@sunnya97 sunnya97 requested a review from a team May 5, 2022 23:53
@sunnya97 sunnya97 marked this pull request as draft May 5, 2022 23:59
@sunnya97 sunnya97 marked this pull request as ready for review May 6, 2022 02:29
This was referenced May 6, 2022
sunnya97 and others added 2 commits May 6, 2022 11:16
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
@sunnya97 sunnya97 merged commit 28761d0 into main May 6, 2022
@sunnya97 sunnya97 deleted the sunny/tokenfactory-mintfee branch May 6, 2022 18:29
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add fee for creating new denoms with x/tokenfactory
3 participants