-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit timeout #2057
Merged
Merged
Commit timeout #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…addat/precommit-timeout
ValarDragon
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! Have you been trying it out on mainnet, whats the precommit inclusion like on blocks you produce?
Closed
Actually yes, and in fact it turned out to work so well that we didn't notice the difference |
czarcas7ic
added a commit
that referenced
this pull request
Sep 15, 2022
This reverts commit 701b391.
p0mvn
pushed a commit
that referenced
this pull request
Sep 17, 2022
ValarDragon
pushed a commit
that referenced
this pull request
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Reduce osmosis block times to about three seconds.
https://ping.pub/evmos/uptime
The trouble with the tm db branch is it is enormous and it is now very different from the mainline. I don't know if it will ever become the mainline. Here is the branch:
tendermint/tm-db#237
This is still very much draft work, and doesn't help with wall clock time at all yet.
Brief Changelog
Please note that these are the only changes that have been made. I am treating additional changes that may be needed because of shorter block times is out of scope for this PR. I also think that it's possible that there are not additional changes needed.
Testing and Verifying
The best test of this code will be to run it on the osmosis test net. It has not yet been tested like that.
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? yes