Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puneet/epochevents #2515

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Puneet/epochevents #2515

merged 3 commits into from
Aug 26, 2022

Conversation

puneet2019
Copy link
Member

@puneet2019 puneet2019 commented Aug 26, 2022 •
edited
Loading

Closes: #XXX

What is the purpose of the change

  • the new error handling mechanism for hooks panicCatchingEpochHook does not append events happening in modules implementing the hooks
  • cacheCtx has events that are not emitted as the cacheCtx is dumped after write() happens.
  • adds ctx.EventManager().EmitEvents(cacheCtx.EventManager().Events())

Brief Changelog

<--! (for example:) -->

  • func panicCatchingEpochHook now emits the events that are part of cacheCtx

Testing and Verifying

  • added the tests to check for events after epochs are called as part of d49cb6a

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no) ~ users no, clients parsing events - yes.
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no) - yes
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented) - not documented

@puneet2019 puneet2019 requested a review from a team August 26, 2022 06:32
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Aug 26, 2022
This was referenced Aug 26, 2022
Merged
Merged
ValarDragon
ValarDragon approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Thanks for doing this

@ValarDragon ValarDragon added A:backport/v10.x backport patches to v10.x branch A:backport/v11.x backport patches to v11.x branch labels Aug 26, 2022
@ValarDragon ValarDragon merged commit 1b5e970 into osmosis-labs:main Aug 26, 2022
@mergify mergify bot mentioned this pull request Aug 26, 2022
Merged
mergify bot pushed a commit that referenced this pull request Aug 26, 2022
@puneet2019 @mergify
Puneet/epochevents (#2515)
646edbe 
* add events from cachectx to main ctx events

* add tests for events from hooks.

* add entry to CHANGELOG.md

(cherry picked from commit 1b5e970)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Aug 26, 2022
Merged
mergify bot pushed a commit that referenced this pull request Aug 26, 2022
@puneet2019 @mergify
Puneet/epochevents (#2515)
49a2b8e 
* add events from cachectx to main ctx events

* add tests for events from hooks.

* add entry to CHANGELOG.md

(cherry picked from commit 1b5e970)

# Conflicts:
#	CHANGELOG.md
ValarDragon added a commit that referenced this pull request Aug 26, 2022
@mergify @puneet2019 @ValarDragon
Puneet/epochevents (backport #2515) (#2517)
05f5f7e 
* Puneet/epochevents (#2515)

* add events from cachectx to main ctx events

* add tests for events from hooks.

* add entry to CHANGELOG.md

(cherry picked from commit 1b5e970)

# Conflicts:
#	CHANGELOG.md

* Fix conflict

Co-authored-by: Puneet <59960662+puneet2019@users.noreply.github.com>
Co-authored-by: Dev Ojha <dojha@berkeley.edu>
ValarDragon added a commit that referenced this pull request Aug 26, 2022
@mergify @puneet2019 @ValarDragon
Puneet/epochevents (backport #2515) (#2516)
a2d8092 
* Puneet/epochevents (#2515)

* add events from cachectx to main ctx events

* add tests for events from hooks.

* add entry to CHANGELOG.md

(cherry picked from commit 1b5e970)

# Conflicts:
#	CHANGELOG.md

* Fix changelog

Co-authored-by: Puneet <59960662+puneet2019@users.noreply.github.com>
Co-authored-by: Dev Ojha <dojha@berkeley.edu>
@ValarDragon ValarDragon mentioned this pull request Aug 26, 2022
Merged
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
A:backport/v10.x backport patches to v10.x branch A:backport/v11.x backport patches to v11.x branch C:docs Improvements or additions to documentation C:x/epochs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puneet2019 @ValarDragon