Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puneet/epochfixs #367

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Puneet/epochfixs #367

merged 3 commits into from
Aug 26, 2022

Conversation

puneet2019
Copy link
Member

1. Overview

osmosis-labs/osmosis#2515

  • emit events from cached ctx from osmosis-epoch

2. Implementation details

  • osmosis has added panic handling for modules that implement the begin blocker hooks, it uses cachectx which is dumped after writing the state.
  • the implementation appends events from cached ctx and adds it to the main ctx.

3. How to test/use

  • relayers are able to catch events if we execute ibc transfer in begin blocker

4. Checklist

  • Does the Readme need to be updated?

@github-actions
Copy link

Coverage after merging puneet/epochfixs into master

29.18%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
simapp
   export.go100%100%15.27%..., 93, 97, 98, 99
   utils.go100%100%20.25%..., 96, 97, 98, 99
   test_helpers.go100%100%0.98%..., 96, 97, 98, 99
   genesis_account.go100%100%100%
   config.go100%100%56.10%..., 72, 73, 74, 75
   genesis.go100%100%100%
   state.go100%100%0%..., 96, 97, 98, 99
   test_suite.go100%100%0%..., 52, 53, 54, 56
   app.go100%100%80.98%..., 587, 588, 591, 592
   encoding.go100%100%100%
simapp/simd/cmd
   root.go100%100%72.69%..., 66, 67, 70, 71
   genaccounts.go100%100%72.44%..., 95, 97, 98, 99
   testnet.go100%100%79.44%..., 408, 409, 62, 63
x/epochs/client/cli
   query.go100%100%0%..., 95, 96, 97, 98
   tx.go100%100%0%..., 22, 23, 24, 25
x/epochs/keeper
   keeper.go100%100%92.86%31
   genesis.go100%100%90.91%14
   hooks.go100%100%100%
   grpc_query.go100%100%43.48%..., 47, 49, 50, 51
   epoch.go100%100%85.71%..., 26, 62, 88, 93
   abci.go100%100%100%
x/epochs/types
   keys.go100%100%0%20, 21, 22
   genesis.pb.go100%100%27.83%..., 96, 97, 98, 99
   identifier.go100%100%0%..., 25, 7, 8, 9
   genesis.go100%100%59.18%..., 57, 58, 61, 62
   hooks.go100%100%100%
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   query.pb.go100%100%2.24%..., 96, 97, 98, 99
x/halving/simulation
   params.go100%100%100%
   genesis.go100%100%100%
x/halving/types
   genesis.go100%100%86.67%25, 26
   halving.pb.go100%100%2.76%..., 96, 97, 98, 99
   genesis.pb.go100%100%2.55%..., 68, 69, 98, 99
   params.go100%100%85.29%23, 24, 25, 43, 44
   query.pb.gw.go100%100%0%..., 95, 96, 97, 98
   query.pb.go100%100%1.91%..., 96, 97, 98, 99

@github-actions
Copy link

Coverage after merging puneet/epochfixs into master

29.18%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
simapp
   app.go100%100%80.98%..., 587, 588, 591, 592
   config.go100%100%56.10%..., 72, 73, 74, 75
   genesis_account.go100%100%100%
   test_suite.go100%100%0%..., 52, 53, 54, 56
   genesis.go100%100%100%
   export.go100%100%15.27%..., 93, 97, 98, 99
   encoding.go100%100%100%
   state.go100%100%0%..., 96, 97, 98, 99
   utils.go100%100%20.25%..., 96, 97, 98, 99
   test_helpers.go100%100%0.98%..., 96, 97, 98, 99
simapp/simd/cmd
   root.go100%100%72.69%..., 66, 67, 70, 71
   testnet.go100%100%79.44%..., 408, 409, 62, 63
   genaccounts.go100%100%72.44%..., 95, 97, 98, 99
x/epochs/client/cli
   tx.go100%100%0%..., 22, 23, 24, 25
   query.go100%100%0%..., 95, 96, 97, 98
x/epochs/keeper
   abci.go100%100%100%
   keeper.go100%100%92.86%31
   epoch.go100%100%85.71%..., 26, 62, 88, 93
   genesis.go100%100%90.91%14
   hooks.go100%100%100%
   grpc_query.go100%100%43.48%..., 47, 49, 50, 51
x/epochs/types
   identifier.go100%100%0%..., 25, 7, 8, 9
   hooks.go100%100%100%
   query.pb.go100%100%2.24%..., 96, 97, 98, 99
   genesis.pb.go100%100%27.83%..., 96, 97, 98, 99
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   keys.go100%100%0%20, 21, 22
   genesis.go100%100%59.18%..., 57, 58, 61, 62
x/halving/simulation
   genesis.go100%100%100%
   params.go100%100%100%
x/halving/types
   query.pb.go100%100%1.91%..., 96, 97, 98, 99
   genesis.pb.go100%100%2.55%..., 68, 69, 98, 99
   genesis.go100%100%86.67%25, 26
   params.go100%100%85.29%23, 24, 25, 43, 44
   query.pb.gw.go100%100%0%..., 95, 96, 97, 98
   halving.pb.go100%100%2.76%..., 96, 97, 98, 99

Copy link

@Anmol1696 Anmol1696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@puneet2019 puneet2019 merged commit 4a0f439 into master Aug 26, 2022
@puneet2019 puneet2019 deleted the puneet/epochfixs branch October 20, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants