Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: indexer config reading sqs enabled value #8431

Merged
merged 2 commits into from
Jun 23, 2024
Merged

fix: indexer config reading sqs enabled value #8431

merged 2 commits into from
Jun 23, 2024

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jun 23, 2024

Closes: #XXX

What is the purpose of the change

Indexer config was reading SQS is-enabled value. Fixed here and did more clean ups as a drive-by. Tested locally.

@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v25.x backport patches to v25.x branch labels Jun 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

@p0mvn p0mvn marked this pull request as ready for review June 23, 2024 20:31
cryptomatictrader
cryptomatictrader approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@cryptomatictrader cryptomatictrader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@cryptomatictrader cryptomatictrader merged commit 725afda into main Jun 23, 2024
1 check passed
@cryptomatictrader cryptomatictrader deleted the roman/fix-indexer-conf branch June 23, 2024 21:36
mergify bot pushed a commit that referenced this pull request Jun 23, 2024
@p0mvn @mergify
fix: indexer config reading sqs enabled value (#8431)
208e76f 
* fix: indexer config reading sqs enabled value

* changelog

(cherry picked from commit 725afda)
@mergify mergify bot mentioned this pull request Jun 23, 2024
Merged
cryptomatictrader pushed a commit that referenced this pull request Jun 23, 2024
@mergify @p0mvn
fix: indexer config reading sqs enabled value (#8431) (#8432)
4cc7cd2 
* fix: indexer config reading sqs enabled value

* changelog

(cherry picked from commit 725afda)

Co-authored-by: Roman <roman@osmosis.team>
@p0mvn p0mvn mentioned this pull request Jun 25, 2024
Merged
@mergify mergify bot mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptomatictrader cryptomatictrader cryptomatictrader approved these changes

Assignees
No one assigned
Labels
A:backport/v25.x backport patches to v25.x branch V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @cryptomatictrader