revert no-install-recommends on ros2 daily images #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruffsl
approved these changes
Apr 6, 2020
I haven't uncovered other issues yet. for the ros and gazebo ones it is not saying much as I just merged the change but haven't PR'd it to the official docker images yet...So noone but people building images themselves have been using them yet. Hoping to leverage things learned on the ros2 images to have better assessment of potential impact on ros and gazebo images. So far the rosdep issue seems ROS 2 specific as almost no package in all ROS 1 (kinetic + melodic) are using the |
|
hmmm that build failure is not expected. |
Currently some overlays would fail to build because of ros-infrastructure/rosdep#752 Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mikaelarguedas
force-pushed
the
revert-no-install-recommends-ros2
branch
from
d23363a to
72c1b66
Compare
|
Rebased on top of #399 and CI is now green. |
mikaelarguedas
added a commit
that referenced
this pull request
Nov 25, 2020
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts temporarily the part of #357 applying to the ros2 devel, source and nightly images.
Currently some overlays would fail to build because of
ros-infrastructure/rosdep#752
(Will fail CI because not matching the templates anymore)
Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com