Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing alternative #542

Merged
merged 8 commits into from
Jun 7, 2021
Merged

Testing alternative #542

merged 8 commits into from
Jun 7, 2021

Conversation

mikaelarguedas
Copy link
Contributor

template based approach to #534
Requires osrf/docker_templates#97

@ruffsl
Copy link
Member

ruffsl commented Jun 6, 2021

If we go that route we'd need to update the CI script accordingly (to expand the template on top of looking for upgrades)

Did you also want to add this testing dockerfile to the CI ROS 2 images workflow?
https://github.com/osrf/docker_images/blob/master/.github/workflows/ros2_ci.yaml

@ruffsl
Copy link
Member

ruffsl commented Jun 7, 2021

Did you also want to add this testing dockerfile to the CI ROS 2 images workflow?

Nevermind, looks like we're not yet calling .ci/ci_script.py from the CI ROS 2 images workflow anyhow.

@ruffsl ruffsl merged commit 33a731c into master Jun 7, 2021
@ruffsl ruffsl deleted the testing-alternative branch June 7, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants