-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert CI image to build from osrf/ros2:testing #2392
Conversation
and modify Dockerfile to account for empty underlay
now that ompl issue is resolved ompl/ompl#753
d05e94a
to
0dae26f
Compare
@SteveMacenski could we wait on #2397 until it's need for it propigates to rolling-testing? |
Builds are passing now when building from rolling-testing repo! |
Awesome!! |
All repos in the |
We've been gradually migrating our CI and development to build from rolling testing as conveyed in the root level Dockerfile. This avoids the need to build a large amount of packages within your underlay, and can save us all a lot of build time. The underlay repo file is still there so if people do need to submit PRs that built against custom versions of dependencies in transit, they still have a way to configure the CI to do that. I've only commented out the repos so folks can easily find and uncomment dependencies that are outside of the core ros2 packages. If you find where the documentation is out of sync, PRs are welcome. Feel free to ping me for review. |
I am not sure if I completely understand it right at the moment. I think you are referring to the CI and I was referring to the description how to build Nav2 on your local machine. The steps to manually build the Nav2 Dependencies describe the following commands to perform:
If you follow these steps, you don't get the repos at the vcs import command, unless you uncomment the repos in the file. Is the solution to add a description that you should look into the underlay.repos file and uncomment the lines that you need? As far as I understand, I needed all lines to be able to build Nav 2. Is that correct? Or is there another way for me to get the rolling dependencies on my development machine? |
* Revert to testing image for CI * Use ompl from testing repo and modify Dockerfile to account for empty underlay * Clean up RUN directive for caching * Revert ros-navigation#2025 now that ompl issue is resolved ompl/ompl#753 * Continue checkout if ccache doesn't yet exist
Reverts parts of: #2348
Depends on: osrf/docker_images#542