Reduce CI Docker images and revert to nightly build #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruffsl
force-pushed
the
ci-simplify-dockerimage
branch
from
4c056c2
to
3c546b0
Compare
to now avoid passing image overlay files into ci caches
from apt-get or rosdep install
ruffsl
force-pushed
the
ci-simplify-dockerimage
branch
from
3c546b0
to
a605fe2
Compare
ruffsl
changed the title
|
@SteveMacenski , you may want to look into the coverage script to see if message packages are still being filtered out correctly: |
SteveMacenski
approved these changes
Jun 2, 2021
|
We have a mix of things removing packages, I don't see it represented in the final result so I think its OK. |
This was referenced Jun 4, 2021
ruffsl
added a commit
to ruffsl/navigation2
that referenced
this pull request
Jul 2, 2021
) * Revert CI to osrf/ros2:nightly * Rename and remove dockerhub files * Use single image for both debug and release jobs * Wipe entire overlay before checkout to now avoid passing image overlay files into ci caches * Split out tester stage * Do not install recommends or suggests packages from apt-get or rosdep install * Only target builder stage for CI image * Rename folder to builder * Update colcon-cache
ruffsl
added a commit
to ruffsl/navigation2
that referenced
this pull request
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With improved CI caching with colcon cache, like PRs using the main branch to seed workspace changes instead of only the docker image, we could reduce the size and number of docker images used for CI. This abbreviated the CI image by deferring the overlay build to CI, and instead just building and installing overlay dependencies within the builder stage in the Dockerfile. This reduces the CI image sizes considerably:
We'll wait to see how #2343 holds up before merging this to switch to using a single CI image for both debug and release jobs.