evaluator-rules: Pull in all missing rules from ORT's example rules #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
pull-in-rules-missing-from-ort-examples
branch
2 times, most recently
from
fb7f7e4 to
6411fa7
Compare
tsteenbe
previously approved these changes
Sep 16, 2022
The evaluator rules in this repository have been created based on ORT's example policy rules, meanwhile they deviated, but are quite redundant. Reduce the deviation use-case-wise by copying all rules from ORT's examples which are missing in this repository using ORT revision [1]. This is the first step towards making the 'ort-config' repository the single dedicated place to examplify policy rules. In the following ORT's example rules will be deleted, or rather minimized and turned into functional test assets, see also [2]. Note: The copied rules have been created as part of [3]. [1] 63e002ba57e7d49c96017fac2ff679de8a5b76df [2] oss-review-toolkit/ort#5701 [3] oss-review-toolkit/ort#5621 Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Signed-off-by: Frank Viernau <frank_viernau@epam.com>
The rule `WRONG_LICENSE_IN_LICENSE_FILE_RULE` has been copied from ORT in a previous change. As that rule is part of the "prior to open sourcing" use case, it makes sense to use the list of approved licenses for the check. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau
force-pushed
the
pull-in-rules-missing-from-ort-examples
branch
from
6411fa7 to
6ed2526
Compare
tsteenbe
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The evaluator rules in this repository have been created based on ORT's example policy rules, meanwhile they deviated, but are quite redundant. Reduce the deviation use-case-wise by copying all rules from ORT's examples which are missing in this repository using ORT revision [1].
This is the first step towards making the 'ort-config' repository the single dedicated place to examplify policy rules. In the following ORT's example rules will be deleted, or rather minimized and turned into functional test assets, see also [2].
Note: The copied rules have been created as part of [3].
[1] 63e002ba57e7d49c96017fac2ff679de8a5b76df
[2] oss-review-toolkit/ort#5701
[3] oss-review-toolkit/ort#5621
Part of: oss-review-toolkit/ort#5621.