Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate redundancy with example policy rules #5701

Open
fviernau opened this issue Aug 26, 2022 · 1 comment
Open

Eliminate redundancy with example policy rules #5701

fviernau opened this issue Aug 26, 2022 · 1 comment
Assignees
@fviernau

Comments

@fviernau
Copy link
Member

Both repositories, ort and ort-config currently contain example policy rules. In fact the ort-config ones have initially been created based on ORT's one and then extended. So, it's currently not clear what the right place for examples rules is.

Fix this as follows:

  • The place for real world examples from now on should be ort-config repository
  • ORT's example policy rules should be moved from examples to functional test assets and be minimized to avoid redundant testing

As a future follow-up (out of scope here) it seems reasonable to add a test which verifies that the rules in ort-config do compile / execute successfully.
@fviernau fviernau self-assigned this Aug 26, 2022
fviernau added a commit to oss-review-toolkit/ort-config that referenced this issue Sep 15, 2022
@fviernau
evaluator-rules: Pull in all missing rules from ORT's example rules
f550f09 
The evaluator rules in this repository have been created based on ORT's
example policy rules, meanwhile they deviated, but are quite redundant.
Reduce the deviation use-case-wise by copying all rules from ORT's
examples which are missing in this repository using ORT revision [1].

This is the first step towards making the 'ort-config' repository the
single dedicated place to examplify policy rules. In the following ORT's
example rules will be deleted, or rather minimized and turned into
functional test assets, see also [2].

[1] 63e002ba57e7d49c96017fac2ff679de8a5b76df
[2] oss-review-toolkit/ort#5701

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau added a commit to oss-review-toolkit/ort-config that referenced this issue Sep 15, 2022
@fviernau
evaluator-rules: Pull in all missing rules from ORT's example rules
b4219e9 
The evaluator rules in this repository have been created based on ORT's
example policy rules, meanwhile they deviated, but are quite redundant.
Reduce the deviation use-case-wise by copying all rules from ORT's
examples which are missing in this repository using ORT revision [1].

This is the first step towards making the 'ort-config' repository the
single dedicated place to examplify policy rules. In the following ORT's
example rules will be deleted, or rather minimized and turned into
functional test assets, see also [2].

Note: The copied rules have been create as part of [3].

[1] 63e002ba57e7d49c96017fac2ff679de8a5b76df
[2] oss-review-toolkit/ort#5701
[3] oss-review-toolkit/ort#5621

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau added a commit to oss-review-toolkit/ort-config that referenced this issue Sep 15, 2022
@fviernau
evaluator-rules: Pull in all missing rules from ORT's example rules
c79a604 
The evaluator rules in this repository have been created based on ORT's
example policy rules, meanwhile they deviated, but are quite redundant.
Reduce the deviation use-case-wise by copying all rules from ORT's
examples which are missing in this repository using ORT revision [1].

This is the first step towards making the 'ort-config' repository the
single dedicated place to examplify policy rules. In the following ORT's
example rules will be deleted, or rather minimized and turned into
functional test assets, see also [2].

Note: The copied rules have been create as part of [3].

[1] 63e002ba57e7d49c96017fac2ff679de8a5b76df
[2] oss-review-toolkit/ort#5701
[3] oss-review-toolkit/ort#5621

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
@fviernau fviernau mentioned this issue Sep 15, 2022
Merged
fviernau added a commit to oss-review-toolkit/ort-config that referenced this issue Sep 15, 2022
@fviernau
evaluator-rules: Pull in all missing rules from ORT's example rules
fb7f7e4 
The evaluator rules in this repository have been created based on ORT's
example policy rules, meanwhile they deviated, but are quite redundant.
Reduce the deviation use-case-wise by copying all rules from ORT's
examples which are missing in this repository using ORT revision [1].

This is the first step towards making the 'ort-config' repository the
single dedicated place to examplify policy rules. In the following ORT's
example rules will be deleted, or rather minimized and turned into
functional test assets, see also [2].

Note: The copied rules have been created as part of [3].

[1] 63e002ba57e7d49c96017fac2ff679de8a5b76df
[2] oss-review-toolkit/ort#5701
[3] oss-review-toolkit/ort#5621

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau added a commit to oss-review-toolkit/ort-config that referenced this issue Sep 16, 2022
@fviernau
evaluator-rules: Pull in all missing rules from ORT's example rules
6411fa7 
The evaluator rules in this repository have been created based on ORT's
example policy rules, meanwhile they deviated, but are quite redundant.
Reduce the deviation use-case-wise by copying all rules from ORT's
examples which are missing in this repository using ORT revision [1].

This is the first step towards making the 'ort-config' repository the
single dedicated place to examplify policy rules. In the following ORT's
example rules will be deleted, or rather minimized and turned into
functional test assets, see also [2].

Note: The copied rules have been created as part of [3].

[1] 63e002ba57e7d49c96017fac2ff679de8a5b76df
[2] oss-review-toolkit/ort#5701
[3] oss-review-toolkit/ort#5621

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau added a commit to oss-review-toolkit/ort-config that referenced this issue Sep 19, 2022
@fviernau
evaluator-rules: Pull in all missing rules from ORT's example rules
7d687ac 
The evaluator rules in this repository have been created based on ORT's
example policy rules, meanwhile they deviated, but are quite redundant.
Reduce the deviation use-case-wise by copying all rules from ORT's
examples which are missing in this repository using ORT revision [1].

This is the first step towards making the 'ort-config' repository the
single dedicated place to examplify policy rules. In the following ORT's
example rules will be deleted, or rather minimized and turned into
functional test assets, see also [2].

Note: The copied rules have been created as part of [3].

[1] 63e002ba57e7d49c96017fac2ff679de8a5b76df
[2] oss-review-toolkit/ort#5701
[3] oss-review-toolkit/ort#5621

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
tsteenbe pushed a commit to oss-review-toolkit/ort-config that referenced this issue Sep 19, 2022
@fviernau @tsteenbe
evaluator-rules: Pull in all missing rules from ORT's example rules
1dd0be9 
The evaluator rules in this repository have been created based on ORT's
example policy rules, meanwhile they deviated, but are quite redundant.
Reduce the deviation use-case-wise by copying all rules from ORT's
examples which are missing in this repository using ORT revision [1].

This is the first step towards making the 'ort-config' repository the
single dedicated place to examplify policy rules. In the following ORT's
example rules will be deleted, or rather minimized and turned into
functional test assets, see also [2].

Note: The copied rules have been created as part of [3].

[1] 63e002ba57e7d49c96017fac2ff679de8a5b76df
[2] oss-review-toolkit/ort#5701
[3] oss-review-toolkit/ort#5621

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
@sschuberth
Copy link
Member

  • The place for real world examples from now on should be ort-config repository

I've given this some though again: I believe it would generally be nice if one could simply clone the ort-config repo to ~/.ort/config and work with it. This is already possible right now (pending this layout fix), but then ~/.ort/config also contains several files / directories that are not used as part of ORT's configuration at all, like the evaluator-rules, notice and notifications directories etc. While that doesn't hurt ORT's operation, it's unclean, and personally I'd prefer to move stuff that's not used as part of ORT's configuration to somewhere else; at least to a subdirectory, but maybe even a different repository, like ort-examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fviernau fviernau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sschuberth @fviernau