examples/rules: Illustrate the OrtResultRule #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial implementation only had error(). Add the two analog functions for the lower severities for completeness. Signed-off-by: Frank Viernau <frank.viernau@here.com>
Prepare for adding an example rule which flags the use of deprecated path exclude reasons. Signed-off-by: Frank Viernau <frank.viernau@here.com>
mnonnenmacher
previously requested changes
Sep 24, 2021
Add a rule which flags the use of deprecated path excludes in the repository configuration. Signed-off-by: Frank Viernau <frank.viernau@here.com>
The size is asserted exactly by shouldContainExactlyInAnyOrder() right below. Signed-off-by: Frank Viernau <frank.viernau@here.com>
Signed-off-by: Frank Viernau <frank.viernau@here.com>
fviernau
force-pushed
the
examples-illustrate-ort-result-rule
branch
from
30b14b9 to
619d282
Compare
mnonnenmacher
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the rule type
OrtResultRulehas been added [1].This PR adds an example.
[1] #4349