evaluator: Add the new rule type OrtResultRule
#4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
ort-result-rule
branch
from
005a135 to
508b342
Compare
mnonnenmacher
requested changes
Aug 10, 2021
Could you amend the commit message with a concrete example for such a use-case? |
fviernau
force-pushed
the
ort-result-rule
branch
from
508b342 to
5fe5ce8
Compare
Done. |
fviernau
force-pushed
the
ort-result-rule
branch
from
5fe5ce8 to
340f2ad
Compare
A rule violation does not necessarily correspond to a specific package. For example it would not make sense to require a package identifier for a rule violation which represents an issue with the (ORT result) labels. Signed-off-by: Frank Viernau <frank.viernau@here.com>
Having a generic rule which is executed once per ORT result helps with use cases for which the more specific rules aren't a good fit. For example, a rule for checking the (ORT result) labels or the repository configuration. Signed-off-by: Frank Viernau <frank.viernau@here.com>
fviernau
force-pushed
the
ort-result-rule
branch
from
340f2ad to
c4ff464
Compare
mnonnenmacher
approved these changes
Sep 17, 2021
Yes, will do a follow-up PR. |
@mnonnenmacher I propose to merge this example: #4499 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a generic rule which is executed once per ORT result helps with use
cases for which the more specific rules aren't a good fit. As a pre-requisite the field
RuleViolation.pkgIdis made nullable, which eliminates the assumption that a rule violation always corresponds to a package.NOTE: The PR has to be amended to properly handle the now nullable attribute in the
web-app.