Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use versions instead of commits #1290

Closed
wants to merge 1 commit into from
Closed

Conversation

OskarStark
Copy link

Or is there a specific reason for the commit hashes?

Signed-off-by: Oskar Stark <oskarstark@googlemail.com>
@spencerschrock
Copy link
Contributor

Or is there a specific reason for the commit hashes?

It's intentional, for security and stability reasons. Here are some resources where we/others try to explain our rationale.

https://github.com/ossf/scorecard/blob/main/docs/checks.md#pinned-dependencies
https://github.com/sethvargo/ratchet#problem-statement

That being said, the versions/SHAs in are README are out of date and could use an update. If you'd like to update them I'd be happy to review the contribution, otherwise feel free to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants