Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions in README #1323

Closed
wants to merge 1 commit into from
Closed

Bump actions in README #1323

wants to merge 1 commit into from

Conversation

Goooler
Copy link

@Goooler Goooler commented Jan 20, 2024

Closes #1287.

Signed-off-by: Goooler <wangzongler@gmail.com>
@spencerschrock
Copy link
Contributor

We try to avoid unpinned actions, see #1290 (comment) for details.

In the README, this makes it easy for things to go out of date. So it's about balancing a trade-off of up-to-date versions with contradicting our own advice.

@Goooler
Copy link
Author

Goooler commented Jan 23, 2024

In the README, this makes it easy for things to go out of date.

Yeah, I was thinking about this too. I suggest we can use major version in README to let users obtain the latest minor updates.

@spencerschrock
Copy link
Contributor

Resolved through #1352. Dependabot will keep the example up-to-date, so we wont need to update it here anymore.

I suggest we can use major version in README

Since our README example is in our control, we are going to advocate for dependency pinning still.
https://docs.github.com/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

I did try to switch our starter workflow to using the major versions since that's annoying to upgrade, but their CONTRIBUTING.md requires the use of hash pinning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Scorecard Installation Template to use actions/checkout on version 4
2 participants