Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 specify that classic personal access tokens are needed #2565

Merged
merged 1 commit into from
Jan 5, 2023
Merged

📖 specify that classic personal access tokens are needed #2565

merged 1 commit into from
Jan 5, 2023

Conversation

mmaraya
Copy link
Contributor

@mmaraya mmaraya commented Dec 22, 2022

Signed-off-by: Mike Maraya mmaraya@users.noreply.github.com

What kind of change does this PR introduce?

Doc update to clarify that classic, not fine-grained, personal access tokens are required for the scorecard CLI to work

(Is it a bug fix, feature, docs update, something else?) docs update

What is the current behavior? documentation currently links to the creation of a fine-grained access token, which produces this error:

Error: RunScorecard: internal error: ListCommits:error during graphqlHandler.setup: internal error: githubv4.Query: non-200 OK status code: 401 Unauthorized body: "{\"message\":\"Personal access tokens with fine grained access do not support the GraphQL API\",\"documentation_url\":\"https://docs.github.com/graphql/guides/forming-calls-with-graphql#authenticating-with-graphql\"}"

What is the new behavior (if this is a feature change)?** n/a, doc change only

  • Tests for the changes have been added (for bug fixes/features): n/a

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

@mmaraya mmaraya temporarily deployed to integration-test December 22, 2022 19:06 — with GitHub Actions Inactive
@github-actions
Copy link

Integration tests success for
[986c6c0]
(https://github.com/ossf/scorecard/actions/runs/3760443316)

@laurentsimon laurentsimon enabled auto-merge (squash) December 22, 2022 20:46
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #2565 (68b8fbd) into main (7c0edac) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2565   +/-   ##
=======================================
  Coverage   40.03%   40.03%           
=======================================
  Files         122      122           
  Lines        9865     9865           
=======================================
  Hits         3949     3949           
  Misses       5635     5635           
  Partials      281      281           

@spencerschrock
Copy link
Member

note: this PR can't be merged due to some CI config problems. see #2508 (comment) for details.

trying to get this cleared up

@github-actions
Copy link

github-actions bot commented Jan 2, 2023

Stale pull request message

Clarified that classic personal access tokens, not fine-grained ones, are needed for scorecard to work.

Signed-off-by: Mike Maraya <mmaraya@users.noreply.github.com>
@naveensrinivasan naveensrinivasan temporarily deployed to integration-test January 5, 2023 18:45 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Integration tests success for
[68b8fbd]
(https://github.com/ossf/scorecard/actions/runs/3849021641)

@laurentsimon laurentsimon merged commit 1d15e9c into ossf:main Jan 5, 2023
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Feb 9, 2023
Clarified that classic personal access tokens, not fine-grained ones, are needed for scorecard to work.

Signed-off-by: Mike Maraya <mmaraya@users.noreply.github.com>

Signed-off-by: Mike Maraya <mmaraya@users.noreply.github.com>
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Apr 4, 2023
Clarified that classic personal access tokens, not fine-grained ones, are needed for scorecard to work.

Signed-off-by: Mike Maraya <mmaraya@users.noreply.github.com>

Signed-off-by: Mike Maraya <mmaraya@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants