-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Switch from paths-ignore to changed-files action to skip required checks. #2566
Conversation
…y changes to pass CI, which are currently blocked waiting for these required checks which will never run due to the path filter. Signed-off-by: Spencer Schrock <sschrock@google.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2566 +/- ##
=======================================
Coverage 40.03% 40.03%
=======================================
Files 122 122
Lines 9865 9865
=======================================
Hits 3949 3949
Misses 5635 5635
Partials 281 281 |
Integration tests success for |
Thanks for this change! Looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
…ince cloud build handles the images. Signed-off-by: Spencer Schrock <sschrock@google.com>
Integration tests success for |
…hecks. (ossf#2566) * Switch from paths-ignore to changed-files action. This allows doc only changes to pass CI, which are currently blocked waiting for these required checks which will never run due to the path filter. Signed-off-by: Spencer Schrock <sschrock@google.com> * Pin checkout action. Disable redundant docker build on push to main since cloud build handles the images. Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock sschrock@google.com
What kind of change does this PR introduce?
CI fix
What is the current behavior?
Due to path filtering, PRs which only change Markdown files will never run the steps in
docker.yml
:scorecard/.github/workflows/docker.yml
Lines 20 to 30 in c6d7680
Since these checks are (currently) required, PRs which only change Markdown files can never be merged. See #2565 and #2508. As long as these checks are required, there's no native way to solve this for reasons summarized well in this blog post.
What is the new behavior (if this is a feature change)?**
A third party action is used to detect doc only changes. Since skipped checks count as passing for required checks, this allows for doc only changes to merge.
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
I tested this with a few PRs in a fork here:
spencerschrock/scorecard-test#3
spencerschrock/scorecard-test#8
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)