✨ GitLab: Documentation and cleaner errors #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Signed-off-by: Raghav Kaul <raghavkaul@google.com>
raghavkaul
requested review from
olivekl,
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan and
spencerschrock
as code owners
raghavkaul
had a problem deploying
to
integration-test
GitHub Actions
Failure
…ess) Signed-off-by: Raghav Kaul <raghavkaul@google.com>
raghavkaul
force-pushed
the
gitlab-checks-unsupported
branch
from
81b4eef
to
7e0af93
Compare
raghavkaul
had a problem deploying
to
integration-test
GitHub Actions
Failure
azeemshaikh38
approved these changes
Apr 6, 2023
|
Stale pull request message |
raghavkaul
had a problem deploying
to
integration-test
GitHub Actions
Failure
raghavkaul
force-pushed
the
gitlab-checks-unsupported
branch
from
8397220
to
bc7dd21
Compare
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
raghavkaul
had a problem deploying
to
integration-test
GitHub Actions
Failure
Signed-off-by: Raghav Kaul <raghavkaul@google.com>
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2821 +/- ##
==========================================
- Coverage 51.66% 51.64% -0.03%
==========================================
Files 158 158
Lines 12064 12075 +11
==========================================
+ Hits 6233 6236 +3
- Misses 5466 5475 +9
+ Partials 365 364 -1 |
balteravishay
pushed a commit
to balteravishay/scorecard
that referenced
this pull request
May 29, 2023
* Return inconclusive if there are no workflows Signed-off-by: Raghav Kaul <raghavkaul@google.com> * Return inconclusive if we don't have any workflows Signed-off-by: Raghav Kaul <raghavkaul@google.com> * logging fixes Signed-off-by: Raghav Kaul <raghavkaul@google.com> * fix panic Signed-off-by: Raghav Kaul <raghavkaul@google.com> * Update README.md Signed-off-by: Raghav Kaul <raghavkaul@google.com> * skip error when getting external status checks (requires full api access) Signed-off-by: Raghav Kaul <raghavkaul@google.com> * update Signed-off-by: Raghav Kaul <raghavkaul@google.com> * fix dangerous workflow test Signed-off-by: Raghav Kaul <raghavkaul@google.com> --------- Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: Avishay <avishay.balter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add documentation for GitLab support and show cleaner error messages (i.e., InconclusiveResult) if a check isn't supported.
Also, some panics are fixed and logging improvements are made.
What is the current behavior?
Currently, we give 10/10 scores to GitLab in certain checks due to lack of data.