🐛 add retry loop to graphQL commit queries which timeout on large github repos #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the event of timeouts, make our pagination smaller Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Going to run a few more tests locally before marking ready for review |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3680 +/- ##
===========================================
- Coverage 76.12% 61.15% -14.98%
===========================================
Files 209 197 -12
Lines 14217 13388 -829
===========================================
- Hits 10823 8187 -2636
- Misses 2749 4674 +1925
+ Partials 645 527 -118 |
|
/scdiff generate |
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Spencer Schrock <sschrock@google.com>
2 tasks
spencerschrock
force-pushed
the
fix/large-repo-graphql
branch
from
3bb76c4
to
bce4649
Compare
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
requested review from
raghavkaul and
laurentsimon
and removed request for
a team
spencerschrock
commented
Nov 17, 2023
laurentsimon
approved these changes
Nov 17, 2023
|
/scdiff generate |
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix
What is the current behavior?
The graphql query which fetches commit data can time out on large repositories.
What is the new behavior (if this is a feature change)?**
On graphql timeout, we now retry the query up to 3 times, cutting our request in half each time.
Which issue(s) this PR fixes
Fixes #3464
Fixes #3663
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)