🌱 allow repo contributors to call scdiff workflow #3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also removes the edited trigger. codecov posts 3 times on each PR, which causes this action to trigger 3x. It is skipped though, so not a huge deal. Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
justaugustus and
laurentsimon
and removed request for
a team
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3683 +/- ##
==========================================
- Coverage 74.92% 68.19% -6.74%
==========================================
Files 209 209
Lines 14217 14217
==========================================
- Hits 10652 9695 -957
- Misses 2942 3959 +1017
+ Partials 623 563 -60 |
laurentsimon
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
workflow fix
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Repo contributors can call scdiff
also removes the edited trigger. codecov edits PR comments a few times, which causes this action to trigger 3x. It ends up skipped though since it doesnt have the command in it, but might as well remove it
Tests for the changes have been added (for bug fixes/features)
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)