Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix nils #3750

Merged
merged 2 commits into from
Dec 28, 2023
Merged

🐛 Fix nils #3750

merged 2 commits into from
Dec 28, 2023

Conversation

naveensrinivasan
Copy link
Member

  • Fixed potential nils.

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)


Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Merging #3750 (05166d0) into main (6a226ce) will decrease coverage by 7.12%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3750      +/-   ##
==========================================
- Coverage   76.02%   68.90%   -7.12%     
==========================================
  Files         227      227              
  Lines       15347    15351       +4     
==========================================
- Hits        11667    10578    -1089     
- Misses       2963     4126    +1163     
+ Partials      717      647      -70     

pkg/json.go Outdated Show resolved Hide resolved
pkg/sarif_test.go Outdated Show resolved Hide resolved
- Fixed potential nils.

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan naveensrinivasan enabled auto-merge (squash) December 28, 2023 15:34
@naveensrinivasan naveensrinivasan merged commit 2bad4e9 into main Dec 28, 2023
37 of 38 checks passed
@naveensrinivasan naveensrinivasan deleted the naveen/fix/potential-nils branch December 28, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants