✨ enforce check scores are between the min and max #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the score is invalid, the Error field is set and the score is replaced with an inconclusive result score. Signed-off-by: Spencer Schrock <sschrock@google.com>
Callers who want the score should use the CreateInconclusiveResult function. The goal is partly to enforce a consistent coding style, and partly to limit proportions which score to -1 accidentally. Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
naveensrinivasan and
justaugustus
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3769 +/- ##
==========================================
- Coverage 75.49% 70.64% -4.86%
==========================================
Files 230 230
Lines 15624 15621 -3
==========================================
- Hits 11795 11035 -760
- Misses 3103 3911 +808
+ Partials 726 675 -51 |
laurentsimon
approved these changes
Jan 12, 2024
|
/scdiff generate |
|
/scdiff generate Dependency-Update-Tool,Packaging,Branch-Protection,Code-Review,Vulnerabilities,CII-Best-Practices,Fuzzing,Pinned-Dependencies,Binary-Artifacts,Token-Permissions,Dangerous-Workflow,License,Maintained,Signed-Releases,Contributors,SAST,Security-Policy,CI-Tests I'll need to debug the scdiff workflow later to see why the "no checks specified" invocation didn't work. |
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature / bug fix combined?
What is the current behavior?
there was no logic on what the scores could be
What is the new behavior (if this is a feature change)?**
if the score is invalid, the Error field is set and the score is replaced with an inconclusive result score.
Which issue(s) this PR fixes
Related to #3766
Special notes for your reviewer
I have this split into two commits, because I'm not certain about forcing callers who want
InconclusiveResultScoreto useCreateInconclusiveResult, but I think it's the right decision. The goal is partly to enforce a consistent coding style, and partly to limit proportions which score to -1 accidentally.Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)